vsfilter.dll is broken
2 posters
Page 1 of 1
vsfilter.dll is broken
Hello
I figured out that vsfilter.dll from k-lite codec pack 14.8.4+ is broken.
vsfilter.dll from k-lite codec pack 14.7.5 still works just fine.
The filter registration is ok.
Replacing the file "C:\Program Files (x86)\K-Lite Codec Pack\Filters\DirectVobSub64\vsfilter.dll" with older version solves the problem.
I'm using vsfilter.dll in my software.
I even submitted some updates to https://github.com/mpc-hc/mpc-hc/tree/develop/src/Subtitles 4 years ago.
I don't see any recent changes in
https://github.com/mpc-hc/mpc-hc/tree/develop/src/filters/transform/VSFilter
or
https://github.com/mpc-hc/mpc-hc/tree/develop/src/Subtitles
I'm trying to figure out what changed in vsfilter.dll and where can I find the sources of vsfilter.dll which is included in k-lite codec pack 14.8.4+
Can someone help me with this?
I see a new filter XySubFilter.dll in k-lite codec pack 14.8.4+
Probably XySubFilter.dll requires a very old version of vsfilter.dll, I have no idea.
If so, please return the latest stable vsfilter.dll
Thanks
I figured out that vsfilter.dll from k-lite codec pack 14.8.4+ is broken.
vsfilter.dll from k-lite codec pack 14.7.5 still works just fine.
The filter registration is ok.
Replacing the file "C:\Program Files (x86)\K-Lite Codec Pack\Filters\DirectVobSub64\vsfilter.dll" with older version solves the problem.
I'm using vsfilter.dll in my software.
I even submitted some updates to https://github.com/mpc-hc/mpc-hc/tree/develop/src/Subtitles 4 years ago.
I don't see any recent changes in
https://github.com/mpc-hc/mpc-hc/tree/develop/src/filters/transform/VSFilter
or
https://github.com/mpc-hc/mpc-hc/tree/develop/src/Subtitles
I'm trying to figure out what changed in vsfilter.dll and where can I find the sources of vsfilter.dll which is included in k-lite codec pack 14.8.4+
Can someone help me with this?
I see a new filter XySubFilter.dll in k-lite codec pack 14.8.4+
Probably XySubFilter.dll requires a very old version of vsfilter.dll, I have no idea.
If so, please return the latest stable vsfilter.dll
Thanks
slydiman- Posts : 8
Join date : 2019-05-10
Re: vsfilter.dll is broken
I see the following in Changelog 14.7.5 to 14.8.4 ~ 2019-03-12:
* Updated DirectVobSub to xy-VSFilter version 8.2.0.802
* Added XySubFilter version 8.2.0.802
Where you get them?
I have found only XySubFilter 3.1.0.752 (October 7, 2018)
https://www.videohelp.com/software/XySubFilter/version-history
And it did not require VSFilter.
I have found only very old xy-VSFilter 3.0.0.306 (December 7, 2014).
Anyway it seems xy-VSFilter does not contain important updates since 2014.
Please return the latest stable VSFilter from MPC-HC repository.
Thanks
* Updated DirectVobSub to xy-VSFilter version 8.2.0.802
* Added XySubFilter version 8.2.0.802
Where you get them?
I have found only XySubFilter 3.1.0.752 (October 7, 2018)
https://www.videohelp.com/software/XySubFilter/version-history
And it did not require VSFilter.
I have found only very old xy-VSFilter 3.0.0.306 (December 7, 2014).
Anyway it seems xy-VSFilter does not contain important updates since 2014.
Please return the latest stable VSFilter from MPC-HC repository.
Thanks
Last edited by slydiman on Sat May 11, 2019 4:46 pm; edited 1 time in total
slydiman- Posts : 8
Join date : 2019-05-10
Re: vsfilter.dll is broken
It is working fine for others. So please provide more details on how you are using it. Through old AviSynth interface?
This is used:
https://github.com/pinterf/xy-VSFilter
This commit may be relevant:
https://github.com/pinterf/xy-VSFilter/commit/e1233b90e2a522d6c4ebd5f5a55f199d770445ce
This is used:
https://github.com/pinterf/xy-VSFilter
This commit may be relevant:
https://github.com/pinterf/xy-VSFilter/commit/e1233b90e2a522d6c4ebd5f5a55f199d770445ce
Re: vsfilter.dll is broken
I have no idea what are improvements of xy-VSFilter vs original VSFilter.
The most important for me is that the original VSFilter uses true 64-bit timestamps internally.
DirectShow interfaces require the REFERENCE_TIME type for timestamps which is 64-bit (100 nsec units).
Old versions of VSFilter and xy-VSFilter use 32-bit msec timestamps internally.
As the result they got corrupted timestamps in case of very long media files and streams.
The most important for me is that the original VSFilter uses true 64-bit timestamps internally.
DirectShow interfaces require the REFERENCE_TIME type for timestamps which is 64-bit (100 nsec units).
Old versions of VSFilter and xy-VSFilter use 32-bit msec timestamps internally.
As the result they got corrupted timestamps in case of very long media files and streams.
Last edited by slydiman on Sat May 11, 2019 5:00 pm; edited 2 times in total
slydiman- Posts : 8
Join date : 2019-05-10
Re: vsfilter.dll is broken
And it seems your Changelog is incorrect.
Must be
* Updated DirectVobSub to xy-VSFilter version 3.2.0.802 (20181031)
instead of 8.2.0.802
Must be
* Updated DirectVobSub to xy-VSFilter version 3.2.0.802 (20181031)
instead of 8.2.0.802
slydiman- Posts : 8
Join date : 2019-05-10
Re: vsfilter.dll is broken
That should be fixable. It is probably missing this:
https://github.com/mpc-hc/mpc-hc/commit/04f914f92c894b43fdead49f7ce50c023826b43b
https://github.com/mpc-hc/mpc-hc/commit/04f914f92c894b43fdead49f7ce50c023826b43b
Re: vsfilter.dll is broken
The problem is:
https://github.com/clsid2/mpc-hc/blob/develop/src/Subtitles/STS.cpp
Line 1950:
void CSimpleTextSubtitle::Add(CStringW str, bool fUnicode, REFERENCE_TIME start, REFERENCE_TIME end, ...
https://github.com/pinterf/xy-VSFilter/blob/master/src/subtitles/STS.cpp
Line 2034:
void CSimpleTextSubtitle::Add(CStringW str, bool fUnicode, int start, int end, ...
etc.
It has been fixed in the original vsfilter (mpc-hc) in 2015.
https://github.com/clsid2/mpc-hc/blob/develop/src/Subtitles/STS.cpp
Line 1950:
void CSimpleTextSubtitle::Add(CStringW str, bool fUnicode, REFERENCE_TIME start, REFERENCE_TIME end, ...
https://github.com/pinterf/xy-VSFilter/blob/master/src/subtitles/STS.cpp
Line 2034:
void CSimpleTextSubtitle::Add(CStringW str, bool fUnicode, int start, int end, ...
etc.
It has been fixed in the original vsfilter (mpc-hc) in 2015.
slydiman- Posts : 8
Join date : 2019-05-10
Re: vsfilter.dll is broken
Admin wrote:That should be fixable. It is probably missing this:
https://github.com/mpc-hc/mpc-hc/commit/04f914f92c894b43fdead49f7ce50c023826b43b
Correct. Who will do it? It was committed in 2015.
Unfortunately https://github.com/clsid2/mpc-hc/releases do not contain vsfilter.dll at all.
And now I should recommend my customers do not install the latest k-lite codec pack because vsfilter.dll is broken.
Luckily 14.7.5 is still available.
I have no idea what to do next.
slydiman- Posts : 8
Join date : 2019-05-10
Re: vsfilter.dll is broken
I tested both versions x64 and x86.
Everything works.
Thank you very much.
Everything works.
Thank you very much.
slydiman- Posts : 8
Join date : 2019-05-10
Page 1 of 1
Permissions in this forum:
You cannot reply to topics in this forum
|
|