Internal Subtitle Renderer not working with .ass subs

I've recently encountered files where the subs don't display with internal but do with Vobsub. The subs source appears to be muxed .ass files.

https://drive.google.com/file/d/1OiY2ppSv7Yl4et7xkPOBVcm0vAsqMIEU/view?usp=sharing

Select the desired subtitle here:
Menu > Play > Subtitle track

For first file the wrong one is selected by default. That will be fixed in future update.

Actually it's more subtle a problem than I thought. I never use the top menus, I just start the video playing, make it full-screen, then r-click and choose my subtitle track. When using this method the subtitles don't display but, once enabled, if I come out of full screen then they do show, and will continue to while back in full screen mode. Odd.

As to defaults, I'm not sure about that issue, but every little improvement helps.

Thanks

Do you have a 4k screen?

MPC-HC options > Subtitles > Texture resolution > 3840x2160

It should normally also work with the default setting, but there seems to be a bug specific to 4k.

Yes, that was it. I have a 4K OLED TV connected to my computer. The Max Texture Resolution was set at 2560x1440 by default, I certainly never touched it. My scaling is set at 250%, if that factors at all. Once I set it to 4K the subs display normally, without having to do anything else. I never encountered this before. The TV isn't new and I watch plenty of things with subtitles, but they are usually srt and pgs, again if that matters. Thanks.

Can you test this debug build?
https://www.sendspace.com/file/pbtemg

Set resolution back to 2560x1440 and let me know if this build fixes it. If not, can you run dbgview.exe to make a log file?

Following the process of opening the portable debug build, then opening the video file through the menus, does allow the subtitles to show correctly, although the max texture resolution still only shows as 1440.

However, when I r-click the video and use 'open with' and target the debug player, the subtitles will not display in this case, unless I come out of fullscreen first.

I believe I used debugview right. I first opened the video with the installed version of MPC-HC and then the debug player.

https://drive.google.com/file/d/1eDI1NKniT196pJtVoGcjBnYj1oKCR1Q8/view?usp=sharing

Weird that the behavior differs when opening through menu versus from Explorer.

Do you have "launch files in fullscreen" enabled? Can you test if disabling that option solves the problem? I am still having difficulty reproducing the problem. But I really want to get this fixed.

I don't see anything from MPC-HC in the log file. You must start debugview before opening a file with MPC-HC.

"Launch files in fullscreen" was actually already disabled, no change when enabling it.

I did start capturing from debugview before I opened the files, I had to run it as admin in order to capture anything. I tried again and included my settings this time, otherwise I don't know what to say. https://drive.google.com/file/d/1_biZXgQCJvdECIbqGKguyyYGJJQ8pyr6/view?usp=sharing

Just from my experience with this issue, it seems like coming out of fullscreen once the subs are enabled makes the subtitle renderer reassess the screen resolution and/or where the subs should be displaying. If I open a video, let it play after enabling subs, occasionally I see huge subs in the corner of the screen, just a letter or two. So they are displaying just not correctly, in the right place.

I was able to reproduce now.

Disable before sub is shown.
Go fullscreen.
Enable.
Now sub is rendered at wrong size.

I'm glad you were able to reproduce. Is the root of the issue still that the texture resolution doesn't detect the 4k res of my TV or something else?

The resolution of your screen does not matter. Subtitle can be rendered at smaller size and still display correctly. It was bug in code where wrong sizes could be set in specific situation, giving wrong scaling.

Test if the problem is solved for you in 16.8.4

I suppose this should be another thread but I wanted to alert you that I updated from 16.8.0 mega to 16.8.4 and when I try to open an file I get the below error. FYI, I did recently update to the latest Visual C++ 2022 version. I downgraded to 16.8.0 and it is working again. So obviously I wasn't able to test the subs issues.

https://drive.google.com/file/d/18jKcPjvkn-EfO_tGsJCexbsjtBkEFYql/view?usp=sharing

That error should be fixed in 16.8.5

I upgraded to 16.8.5 and the subs issues appears to be resolved. Thanks. However, whenever I open a video the below error displays. The video plays normally underneath the error, but you must click OK before you can interact with anything.

https://drive.google.com/file/d/1oz3qGxHVvcnxK3-fGC0tU9DxxrHJjnIb/view?usp=sharing

That was already fixed in latest version.